Move parameters to init.pp + more data types#800
Draft
ekohl wants to merge 8 commits intotheforeman:masterfrom
Draft
Move parameters to init.pp + more data types#800ekohl wants to merge 8 commits intotheforeman:masterfrom
ekohl wants to merge 8 commits intotheforeman:masterfrom
Conversation
The fact function returns undef if the fact doesn't exist. This simplifies the code.
These parameters have a sane default and doesn't need to be in the config.
Since Puppet 4 the agent runs as root and the package doesn't create the user & group anymore. Only the server runs as a limited user. This means the parameters are no longer needed.
This makes it easier to maintain due to a better readability. It also makes puppet-strings' default values more useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to maintain due to a better readability. It also makes puppet-strings' default values more useful, even if right now we don't publish that.