Skip to content

fix(file-naming): sync Frappe File record after physical file move #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oval17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(file-naming): sync Frappe File record after physical file move #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion my_app/helper/file_naming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@
def file_retitling(original_file_url: str, folder_suffix: str, name: str) -> dict:
"""
Renames the uploaded video filename using the generated name for that video_info record,
and returns file metadata as a dictionary.
moves it into a sub-folder, and returns file metadata as a dictionary.

Also updates the Frappe File doctype record so that Frappe's internal file
management stays in sync with the new physical location. Without this step,
the old File record retains the original (now broken) file_url, causing
Frappe to treat the attachment as missing and potentially re-upload the file
on the next save — resulting in duplicate entries under /files/original/.

Args:
original_file_url (str): The URL to the original uploaded file (e.g., /files/sample123.mp4).
Expand Down Expand Up @@ -39,6 +45,16 @@ def file_retitling(original_file_url: str, folder_suffix: str, name: str) -> dic

new_file_url_doc = f"/files/{folder_suffix}/{new_filename}"

# Sync the Frappe File doctype record to the new location.
# shutil.move() updates only the physical file; without updating the File
# record, Frappe still holds a reference to the old (now missing) path.
# On the next document save Frappe may re-upload the file, producing a
# duplicate entry in /files/original/.
file_doc_name = frappe.db.get_value("File", {"file_url": original_file_url}, "name")
if file_doc_name:
frappe.db.set_value("File", file_doc_name, "file_url", new_file_url_doc)
frappe.db.commit()

file_info = {
"original_filename": original_filename,
"original_filepath": original_path,
Expand Down