Add timeout for custom menu commits#164
Open
mini-ninja-64 wants to merge 2 commits intothe-via:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello while implementing a custom menu for my device I found what appears to be a disagreement between the documentation and behaviour of VIA.
The VIA docs currently state the following:
However the current VIA codebase will push a custom menu save command for every custom menu set it does, this is not ideal for the EEPROM as such it would be best in my opinion to defer writing to the EEPROM until we are sure that the user has settled on a value.
To fix this I have offloaded the sending of a custom menu save command to a function that is executed only once 250ms has passed without any custom menu updates.
I am very happy to update and change the solution chosen as there are of course multiple ways to proceed with this problem, including moving the tackling of EEPROM save timing to firmware.
I was also unsure whether or not I should open an associated issue to link to this PR, let me know if that would be useful.