Fix #1238: Wire trigger index loading and add kg list --pinned command#862
Open
AlexMikhalev wants to merge 1 commit intomainfrom
Open
Fix #1238: Wire trigger index loading and add kg list --pinned command#862AlexMikhalev wants to merge 1 commit intomainfrom
AlexMikhalev wants to merge 1 commit intomainfrom
Conversation
- Add extract_triggers_from_kg() helper in terraphim_config to parse markdown directives and extract trigger:: and pinned:: entries - Wire load_trigger_index() after RoleGraph construction in all three code paths: automata_path success, local KG fallback, and local KG direct build - Update auto_route.rs to use find_matching_node_ids_with_fallback() instead of find_matching_node_ids() for concept scoring - Add CLI command matching spec request Refs #1238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements fixes for spec gaps identified in issue #1238:
Changes
Wire
load_trigger_index()in production (terraphim_config/src/lib.rs)extract_triggers_from_kg()helper to parse markdown directives and extracttrigger::andpinned::entriesUpdate auto-routing to use trigger fallback (
terraphim_service/src/auto_route.rs)score_distinct_concepts()to usefind_matching_node_ids_with_fallback()Add
kg list --pinnedCLI command (terraphim_agent/src/main.rs)Kgcommand withlistsubcommand matching spec requestVerification
cargo check --workspacepassescargo clippy --workspace -- -D warningspassescargo fmt --all -- --checkpassescargo test -p terraphim_config -p terraphim_service -p terraphim_rolegraph --libpassesRefs #1238