Remove beforeEach and afterEach test methods#44
Open
MoonBow-1 wants to merge 3 commits into
Open
Conversation
- Removes @beforeeach, @AfterEach etc. annotations from tests - Initializes the server in each of the test methods - ConfigurationIT is the only test left which is a SpringBootTest, that checks the Spring Boot autowiring
- Most likely a Thread related problem - Also fixes acks not being able to be acked due to Futures - Needs confirming
Tiihott
requested changes
May 20, 2026
Tiihott
left a comment
Tiihott
left a comment
There was a problem hiding this comment.
Tests pass and beforeEach/afterEach removals look ok, but there is one removed assertion that looks like it should still be used.
|
|
||
| assertEquals(expected, configuration.toString()); | ||
| assertEquals(0, messageList.size()); | ||
| assertEquals(1, openCount.get()); |
There was a problem hiding this comment.
Why was the closeCount assertion removed?
Contributor
Author
There was a problem hiding this comment.
This accidentally deleted, and added back in commit c5a6b25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31
Configuration integration test is the only exception, where a SpringBootTest is testing the autowired values for the configuration