Refactor version retrieval in setup.py to read from __init__.py#986
Refactor version retrieval in setup.py to read from __init__.py#986mhucka merged 8 commits intotensorflow:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mhucka
added
the
area/health
|
@whyvineet could you go ahead and look into signing the contributor's license agreement (CLA) mentioned by the google-cla bot comment earlier on this PR? I realize that the concept of a CLA may be something unfamiliar. It is a common request by companies to external contributors. It allows contributors to Google open-source projects to retain ownership of their code while granting Google the necessary rights to use those contributions. The CLA covers all Google projects, and it only needs to be signed once. |
|
Hey @mhucka, I have already signed the CLA. |
Oh, sorry about that! I should have checked first. Thanks for taking care of that, and for your work. |
|
@whyvineet Could you go ahead and update this branch? (I could also do it, but it's generally better if contributors do it themselves.) |
Changes: 1. Make it use `Path(__file__).resolve().parent` to be more robust about resolving file paths. 2. Look for `__init__.py` in a couple of places because of different contexts in which setup.py may be called.
|
@whyvineet I took the liberty of making some small changes to the code, and pushed the changes to your branch. Things are testing successfully in CI. If you are happy with the changes, I will merge this PR. |
|
Thanks @mhucka for fixing the CI checks... Feel free to go ahead and merge the PR. |
mhucka
left a comment
mhucka
left a comment
There was a problem hiding this comment.
Thank you for doing this! And for your patience :-).
2 participants
Resolves #914