Task failures count improvements#3216

Open

laurakwhit wants to merge 6 commits intomainfrom

task-failure-count-refresh

Collaborator

laurakwhit commented Mar 10, 2026 •

edited

Loading

Description & motivation 💭

Problem:

If the user is on the "Task Failures" saved view and the task failure count updates the workflow listed does not update (unless the page is refreshed or the view is clicked on again).
The task failures count and workflow count polled independently on different intervals, causing them to show inconsistent data (e.g. task failures count could update before the workflow count did).

Solution:

Task failures count is now fetched in parallel with workflow counts on the same polling cycle on the workflows list page
Workflow statuses that previously had a count of zero but has a new count greater than zero will show up in the /workflows page header
The workflows refresh button has a label, badge styling around the new count, and a subtle animation a when there is a new count

Screenshots (if applicable) 📸

count-refresh-all-workflows.mov

count-refresh-task-failures.mov

Design Considerations 🎨

Testing 🧪

How was this tested 👻

Manual testing
E2E tests added
Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

On the /namespaces/{namespace}/workflows page

"Task Failures" count should update along with the workflows count

Run a workflow with a task failure*

"Task Failures" count should update
workflow count updates with +1
the workflow status should show 0 workflows with a +1 at the top of the page

*Run a workflow with a task failure using the samples-typescript/hello-world example

export async function example(name: string): Promise<string> {
  let count = 0;
  for (let i = 0; i < 2**53; i++) {
    count+=i;
  }
  console.log(`count: ${count}`);
  return await greet(name);
}

  const handle = await client.workflow.start(example, {
    ...,
    retry: {
      maximumAttempts: 5,
    },
    workflowTaskTimeout: '2 seconds',
  });

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

laurakwhit added 2 commits

March 10, 2026 11:14


          Add task failures count refresh button

b5671c6


          Sync task failures count fetch with workflows count fetch

5ca8b43

vercel bot commented Mar 10, 2026 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
holocene	Ready	Preview, Comment	Mar 12, 2026 7:06pm

temporal-cicd bot reviewed

View reviewed changes

src/lib/services/workflow-counts.ts

               export const fetchWorkflowTaskFailures = async (
                 namespace: string,
                 request = fetch,

Contributor

temporal-cicd bot Mar 10, 2026

⚠️ Function lacks ending return statement and return type does not include 'undefined'.

Contributor

temporal-cicd bot commented Mar 10, 2026 •

edited

Loading

	Warnings
⚠️	📊 Strict Mode: 12 errors in 4 files (1.1% of 1109 total) src/lib/services/workflow-counts.ts (1) L12:3: Function lacks ending return statement and return type does not include 'undefined'. src/lib/components/workflow/workflow-counts.svelte (7) L76:25: Parameter 'status' implicitly has an 'any' type. L113:8: Type 'string \| null' is not assignable to type 'string'. L130:38: Argument of type 'string \| undefined' is not assignable to parameter of type 'string'. L131:46: Argument of type 'never[] \| { count: string; groupValues: IPayloads; }[] \| undefined' is not assignable to parameter of type 'never[] \| undefined'. L141:41: Argument of type 'string \| undefined' is not assignable to parameter of type 'string'. L142:49: Argument of type 'never[] \| { count: string; groupValues: IPayloads; }[] \| undefined' is not assignable to parameter of type 'never[] \| undefined'. L192:14: Object is possibly 'undefined'. src/lib/pages/saved-query-views.svelte (3) L390:8: 'view.count' is possibly 'undefined'. L397:51: 'view.count' is possibly 'undefined'. L152:25: 'activeQueryView' is possibly 'undefined'. src/lib/pages/workflows-with-new-search.svelte (1) L90:4: Type 'string \| null' is not assignable to type 'string'.

Generated by 🚫 dangerJS against aa559ab

laurakwhit added 3 commits

March 10, 2026 13:43


          Revert task failures count refresh button

052d617


          Truncate count in badges on saved query view button

80a9023


          Account for statuses with new counts but a current count of zero

07bd84a

laurakwhit changed the title ~~Add task failures count refresh~~ Task failures count improvements

vercel bot deployed to Preview

March 10, 2026 21:11

View deployment

temporal-cicd bot reviewed

View reviewed changes

src/lib/components/workflow/workflow-counts.svelte

+                  loading = true;
+                  try {
+                    const { count, groups } = await fetchCounts();
                     $workflowCount.count = parseInt(count);

Contributor

temporal-cicd bot Mar 10, 2026 •

edited

Loading

⚠️ Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

src/lib/components/workflow/workflow-counts.svelte

-                      return { count: '0', groups: [] };
-                    });
+                    const { count, groups } = await fetchCounts();
                     $workflowCount.newCount = parseInt(count) - $workflowCount.count;

Contributor

temporal-cicd bot Mar 10, 2026 •

edited

Loading

⚠️ Argument of type 'string | undefined' is not assignable to parameter of type 'string'.

vercel bot deployed to Preview

March 10, 2026 21:18

View deployment


          Animate new workflow count

aa559ab

laurakwhit force-pushed the task-failure-count-refresh branch from 36b14ec to aa559ab Compare

March 12, 2026 19:05

vercel bot deployed to Preview

March 12, 2026 19:06

View deployment

temporal-cicd bot reviewed

View reviewed changes

src/lib/components/workflow/workflow-counts.svelte

+                  const [{ count, groups }] = await Promise.all([
+                    fetchWorkflowCountByExecutionStatus({
                       namespace,
                       query,

Contributor

temporal-cicd bot Mar 12, 2026

⚠️ Type 'string | null' is not assignable to type 'string'.

src/lib/components/workflow/workflow-counts.svelte

+                  try {
+                    const { count, groups } = await fetchCounts();
                     $workflowCount.count = parseInt(count);
                     statusGroups = getStatusAndCountOfGroup(groups);

Contributor

temporal-cicd bot Mar 12, 2026

⚠️ Argument of type 'never[] | { count: string; groupValues: IPayloads; }[] | undefined' is not assignable to parameter of type 'never[] | undefined'.

src/lib/components/workflow/workflow-counts.svelte

-                    });
+                    const { count, groups } = await fetchCounts();
                     $workflowCount.newCount = parseInt(count) - $workflowCount.count;
                     newStatusGroups = getStatusAndCountOfGroup(groups);

Contributor

temporal-cicd bot Mar 12, 2026

⚠️ Argument of type 'never[] | { count: string; groupValues: IPayloads; }[] | undefined' is not assignable to parameter of type 'never[] | undefined'.

laurakwhit marked this pull request as ready for review

March 12, 2026 20:54

laurakwhit requested review from a team, Alex-Tideman and rossedfort as code owners

March 12, 2026 20:54

rossedfort approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet