Skip to content

refactor(workflow): remove minimizeEventView store #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossnelson merged 3 commits into from
Mar 19, 2026
Merged

refactor(workflow): remove minimizeEventView store #3182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ef25f4
refactor(workflow): remove minimizeEventView store
rossnelson Feb 24, 2026
2c023fc
Remove minimzed from event-type-filter
Alex-Tideman Mar 19, 2026
905b968
Remove minimized prop
Alex-Tideman Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/lib/components/lines-and-dots/event-type-filter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import { CategoryIcon } from './constants';

export let compact = false;
export let minimized = true;

let open = writable(false);

Expand Down Expand Up @@ -120,7 +119,7 @@
<Menu
id="event-type-menu"
keepOpen
position={minimized ? 'top-right' : 'right'}
position="right"
class="w-[220px] md:w-[360px]"
>
<MenuItem data-testid={translate('common.all')} onclick={onAllClick}>
Expand Down
52 changes: 24 additions & 28 deletions src/lib/components/workflow/input-and-results-payload.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<script lang="ts">
import CodeBlock from '$lib/holocene/code-block.svelte';
import { translate } from '$lib/i18n/translate';
import { minimizeEventView } from '$lib/stores/event-view';
import type { Payload } from '$lib/types';
import type { PotentiallyDecodable } from '$lib/utilities/decode-payload';
import {
Expand Down Expand Up @@ -51,46 +50,43 @@
{title}
</h3>
{#if content}
{#key $minimizeEventView}
{#if payloadsSize > 0}
<PayloadDecoder value={parsedContent} key="payloads">
{#snippet children(decodedValue)}
{#if payloadsSize > 1}
{#each parsePayloads(decodedValue) as decodedContent}
<CodeBlock
content={stringifyWithBigInt(decodedContent)}
copyIconTitle={translate('common.copy-icon-title')}
copySuccessIconTitle={translate(
'common.copy-success-icon-title',
)}
maxHeight={300}
/>
{/each}
{:else}
{#if payloadsSize > 0}
<PayloadDecoder value={parsedContent} key="payloads">
{#snippet children(decodedValue)}
{#if payloadsSize > 1}
{#each parsePayloads(decodedValue) as decodedContent}
<CodeBlock
content={decodedValue}
content={stringifyWithBigInt(decodedContent)}
copyIconTitle={translate('common.copy-icon-title')}
copySuccessIconTitle={translate(
'common.copy-success-icon-title',
)}
maxHeight={300}
/>
{/if}
{/snippet}
</PayloadDecoder>
{:else}
<PayloadDecoder value={parseWithBigInt(content)}>
{#snippet children(decodedValue)}
{/each}
{:else}
<CodeBlock
content={decodedValue}
copyIconTitle={translate('common.copy-icon-title')}
copySuccessIconTitle={translate('common.copy-success-icon-title')}
maxHeight={300}
/>
{/snippet}
</PayloadDecoder>
{/if}
{/key}
{/if}
{/snippet}
</PayloadDecoder>
{:else}
<PayloadDecoder value={parseWithBigInt(content)}>
{#snippet children(decodedValue)}
<CodeBlock
content={decodedValue}
copyIconTitle={translate('common.copy-icon-title')}
copySuccessIconTitle={translate('common.copy-success-icon-title')}
minHeight={120}
maxHeight={120}
/>
{/snippet}
</PayloadDecoder>
{/if}
{:else}
<CodeBlock
content={isPending ? 'Results will appear upon completion.' : 'null'}
Expand Down
8 changes: 2 additions & 6 deletions src/lib/layouts/workflow-history-layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@
import { isCategoryType } from '$lib/models/event-history/get-event-categorization';
import WorkflowHistoryJson from '$lib/pages/workflow-history-json.svelte';
import { clearActives } from '$lib/stores/active-events';
import {
eventFilterSort,
eventViewType,
minimizeEventView,
} from '$lib/stores/event-view';
import { eventFilterSort, eventViewType } from '$lib/stores/event-view';
import {
currentEventHistory,
filteredEventHistory,
Expand Down Expand Up @@ -197,7 +193,7 @@
: translate('common.ascending')}
</ToggleButton>
{/if}
<EventTypeFilter {compact} minimized={$minimizeEventView} />
<EventTypeFilter {compact} />
<ToggleButton
Comment thread
Alex-Tideman marked this conversation as resolved.
disabled={isNotPending}
data-testid="pause"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layouts/workflow-timeline-layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
on:click={onSort}
size="sm">{reverseSort ? 'Descending' : 'Ascending'}</ToggleButton
>
<EventTypeFilter compact={false} minimized={false} />
<EventTypeFilter compact={false} />
<ToggleButton
Comment thread
Alex-Tideman marked this conversation as resolved.
disabled={isNotPending}
data-testid="pause"
Expand Down
2 changes: 0 additions & 2 deletions src/lib/stores/event-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ export const autoRefreshWorkflow = persistStore<'on' | 'off'>(

export const eventViewType = persistStore<EventView>('eventView', 'feed', true);

export const minimizeEventView = persistStore('minimizeEventView', true, true);

export const eventFilterSort = persistStore<EventSortOrder>(
'eventFilterSort',
'descending',
Expand Down
Loading