Skip to content

Narrow overloads on the SANO client#1552

Merged
VegetarianOrc merged 6 commits into
mainfrom
amazzeo/narrow-sano-overloads
May 22, 2026
Merged

Narrow overloads on the SANO client#1552
VegetarianOrc merged 6 commits into
mainfrom
amazzeo/narrow-sano-overloads

Conversation

@VegetarianOrc
Copy link
Copy Markdown
Contributor

What was changed

Remove broad callable overloads on the SANO Nexus Client.

Why?

The SANO Nexus Client should be more opinionated the types of callables it receives and how it derives output.

Checklist

  1. How was this tested:
  • Existing tests
  • Update some test cases in the type tests that demonstrated conflicting types between passed callables and result_types to demonstrate that it isn't supported

@VegetarianOrc VegetarianOrc requested a review from a team as a code owner May 21, 2026 19:24
Copy link
Copy Markdown

@Evanthx Evanthx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VegetarianOrc VegetarianOrc enabled auto-merge (squash) May 22, 2026 17:37
@VegetarianOrc VegetarianOrc merged commit 91abc81 into main May 22, 2026
25 of 27 checks passed
@VegetarianOrc VegetarianOrc deleted the amazzeo/narrow-sano-overloads branch May 22, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants