-
Notifications
You must be signed in to change notification settings - Fork 188
Experimental: External Payload Storage #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
71cff0d
External payload storage
jmaeagle99 086640b
Remove external converter in favor of payload codec
jmaeagle99 8c7b418
Replace DriverError and DriverNotFoundError with RuntimeError
jmaeagle99 e4883d1
Import exstore module instead of types
jmaeagle99 c39be13
Remove DriverSelector
jmaeagle99 354888e
Remove PayloadNotFoundError in favor of non-retryable ApplicationError
jmaeagle99 9da8504
Renames and doc updates
jmaeagle99 cab33e2
Remove unused import
jmaeagle99 3fffe91
Formatting
jmaeagle99 734088a
Undo breaking changes
jmaeagle99 a0ddf52
Rename field
jmaeagle99 89ac04f
Use mapping instead of dict
jmaeagle99 f983904
Merge branch 'main' into extstore
jmaeagle99 f993741
Raise exception for duplicate drivers
jmaeagle99 62200f2
Fix storage impl initialization
jmaeagle99 790dc57
Reformat and add doc string
jmaeagle99 fb562c9
Remove WithSerializationContext for storage types that receive a Stor…
jmaeagle99 e50a8e6
Update driver selector to return driver name and update README sample.
jmaeagle99 2e03402
Raise ValueError instead of RuntimeError
jmaeagle99 c6609ab
Remove asserts
jmaeagle99 9539f59
Move extstore to non-public submodule of converter
jmaeagle99 b7a331b
Rename StorageConfig to ExternalStorage
jmaeagle99 28b6afb
Merge _StorageImpl into ExternalStorage
jmaeagle99 9206d66
Must have atleast one driver
jmaeagle99 a16cd76
Cleanup customer warning and remove unnecessary fields
jmaeagle99 ab7fc43
Move size check to driver selector wrapper method
jmaeagle99 8bf9f8d
Separate context to store and retrieve contexts
jmaeagle99 3a9507a
Make methods non-public
jmaeagle99 debe723
Fix linting violations
jmaeagle99 fe8e253
Cancel in-flight operations if a driver raises exception
jmaeagle99 63943d0
Fix doc strings
jmaeagle99 d384f2e
Update readme
jmaeagle99 0230957
Merge branch 'main' into extstore
jmaeagle99 f3b8aec
Add test to validate driver concurrency
jmaeagle99 86a6514
Change driver selector back to returning driver instance
jmaeagle99 82dbddb
Add test demonstrating a basic customer scenario
jmaeagle99 18cce91
Remove unused class
jmaeagle99 7a6b36b
Fix test comments
jmaeagle99 7dbd512
Doc updates
jmaeagle99 aa7cfba
Reverse the steps of codecs and external storage
jmaeagle99 3f4c3af
Remove ExternalStorage.payload_codec
jmaeagle99 ba7ef89
Reformat
jmaeagle99 7573092
Update tests with fuller message validation
jmaeagle99 953727e
Merge branch 'main' into extstore
jmaeagle99 f83fd4f
Merge branch 'main' into extstore
jmaeagle99 9ea70df
Rename StorageDriverClaim data to claim_data
jmaeagle99 28d2996
Require driver_selector if multiple drivers are registered
jmaeagle99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.