Skip to content

fix(tests): wait for routing config propagation in worker deployment ramp test #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmaeagle99 merged 2 commits into from
May 15, 2026
+13 −0
Merged

fix(tests): wait for routing config propagation in worker deployment ramp test #705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60850db
fix(tests): wait for routing config propagation in worker deployment …
jmaeagle99 May 15, 2026
73b3b0e
Merge branch 'main' into fix-700
jmaeagle99 May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/Temporalio.Tests/Worker/WorkerDeploymentVersioningTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,15 @@ async Task ExecuteRampTest()
// Set current version to v1 and ramp v2 to 100%
var conflictToken = (await TestUtils.SetCurrentDeploymentVersionAsync(
Client, describeResp.ConflictToken, v1)).ConflictToken;

await TestUtils.WaitForRoutingConfigPropagationAsync(Client, deploymentName, v1.BuildId);

conflictToken = (await TestUtils.SetRampingVersionAsync(
Client, conflictToken, v2, 100)).ConflictToken;

await TestUtils.WaitForRoutingConfigPropagationAsync(
Client, deploymentName, v1.BuildId, v2.BuildId);

// Run workflows and verify they run on v2
for (int i = 0; i < 3; i++)
{
Expand All @@ -210,6 +216,10 @@ async Task ExecuteRampTest()

// Set ramp to 0, expecting workflows to run on v1
conflictToken = (await TestUtils.SetRampingVersionAsync(Client, conflictToken, v2, 0)).ConflictToken;

await TestUtils.WaitForRoutingConfigPropagationAsync(
Client, deploymentName, v1.BuildId, v2.BuildId);

for (int i = 0; i < 3; i++)
{
var wfa = await Client.StartWorkflowAsync(
Expand All @@ -223,6 +233,9 @@ async Task ExecuteRampTest()
// Set ramp to 50 and eventually verify workflows run on both versions
await TestUtils.SetRampingVersionAsync(Client, conflictToken, v2, 50);

await TestUtils.WaitForRoutingConfigPropagationAsync(
Client, deploymentName, v1.BuildId, v2.BuildId);

var seenResults = new HashSet<string>();

async Task<string> RunAndRecord()
Expand Down
Loading