External storage and codec server sample#474
Conversation
| signal.Notify(sigCh, os.Interrupt) | ||
| select { | ||
| case <-sigCh: | ||
| _ = srv.Close() |
There was a problem hiding this comment.
In a production codec server, we would want to drain current requests/tasks before shutting down right? I don't know if we offer guidance on this or it's just a "yea you should know that" kind of thing. I don't have strong feelings about mentioning that here or not because it might be too in the weeds.
There was a problem hiding this comment.
These samples tend to be about how to use features, not necessarily about production best practices. However, in the case of codec servers, it might be warranted since these are our main demonstrations of these types of servers. I can do a separate follow up for this.
yuandrew
left a comment
yuandrew
left a comment
There was a problem hiding this comment.
It would be good to have a test, most of our samples have a test to go with it, I guess for when we bump the SDK version, we have another sanity check?
3 participants
What was changed
Add sample for external storage with codec server that supports multiple namespaces and downloads.
Why?
Provide a baseline reference for how to use external storage with the S3 driver and an updated codec server.
Checklist