[#761]: feat(protocol): ensure LocalActivityParams includes required SDK fields#761
Merged
Conversation
rustatian
added
the
C-enhancement
- Added `DataConverter`, `FailureConverter`, and `Attempt` fields to `LocalActivityParams`. - Avoided potential nil-pointer dereference in Go SDK. - Introduced unit tests to validate required field population and default values.
rustatian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataConverter,FailureConverter, andAttemptfields toLocalActivityParams.Reason for This PR
[Author TODO: add issue # or explain reasoning.]Description of Changes
[Author TODO: add description of changes.]License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.