Add request header annotation and resource-id fields#728
Open
tconley1428 wants to merge 6 commits intomasterfrom
Open
Add request header annotation and resource-id fields#728tconley1428 wants to merge 6 commits intomasterfrom
tconley1428 wants to merge 6 commits intomasterfrom
Conversation
Implements request header routing annotations and resource_id fields for: - Workflow execution APIs (17 endpoints) - workflow:workflow_id - Workflow task APIs (4 endpoints) - workflow:workflow_id - Activity APIs (12 endpoints) - workflow:workflow_id or activity:activity_id - Schedule APIs (6 endpoints) - schedule:schedule_id - Batch operation APIs (3 endpoints) - batch:job_id - Nexus task APIs (2 endpoints) - routingId:server_routing_id - Task queue APIs (3 endpoints) - taskqueue:task_queue_name - Worker APIs (4 endpoints) - worker:worker_grouping_key - Worker deployment APIs (8 endpoints) - deployment:deployment_name Added resource_id fields to request messages that use task tokens and server_routing_id field to PollNexusTaskQueueResponse for proper routing. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Corrected the field path from {workflow_execution.workflow_id} to
{update_ref.workflow_execution.workflow_id} since PollWorkflowExecutionUpdateRequest
uses update_ref field that contains the WorkflowExecution.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Added resource_id fields to RecordWorkerHeartbeatRequest, FetchWorkerConfigRequest,
and UpdateWorkerConfigRequest for proper routing support. Updated annotations to
use {resource_id} instead of {worker_grouping_key} for consistency.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Changed server_routing_id fields to resource_id in Nexus request/response
messages and updated annotations to use {resource_id} for consistency
with other APIs.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
tconley1428
changed the title
Sushisource
approved these changes
Mar 12, 2026
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
Makes sense to me. I haven't meticulously checked that every path is valid.
|
|
||
| import "google/protobuf/descriptor.proto"; | ||
|
|
||
| // RequestHeaderAnnotation allows specifying that field values from a request |
Member
There was a problem hiding this comment.
Suggested change
| // RequestHeaderAnnotation allows specifying that field values from a request | |
| // Allows specifying that field values from a request |
Go stuttering feels weird outside of Go (one of the variety of things I think is just silly in the language in general)
bergundy
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READ BEFORE MERGING: All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted.
Adding a proto annotation to be used for automatically propagating message fields into headers. Will be accompanied by SDK changes to generate code for doing so based on the annotations. See temporalio/api-go#236 and temporalio/sdk-go#2226 for example.
Also adds additional
resource-idfields to a number of messages for use in routing.MCN support
Breaking changes
Server PR