Add a new workflow path in rerouting FSMs to skip rerouting#5526
Open
dmitrii-beliakov wants to merge 1 commit intodevelopfrom
Open
Add a new workflow path in rerouting FSMs to skip rerouting#5526dmitrii-beliakov wants to merge 1 commit intodevelopfrom
dmitrii-beliakov wants to merge 1 commit intodevelopfrom
Conversation
dmitrii-beliakov
requested review from
IvanChupin,
pablomuri,
pkazlenka and
yuliiamir
IvanChupin
approved these changes
Jan 3, 2024
dmitrii-beliakov
force-pushed
the
fix/history_reroute
branch
from
1c591a4 to
9608fc9
Compare
…s not needed because the flow is already in the UP state.
dmitrii-beliakov
force-pushed
the
fix/history_reroute
branch
from
9608fc9 to
c425ca5
Compare
Collaborator
Author
|
It's been some time ago, I think there was a problem because some of the tests relies on the history outcome, which has changed. Please double check the test failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new behavior when a flow or HA-flow transits from DOWN to UP state and automatic reroute is invoked. In case, when there is only one path which goes down and then up, automatic reroute cannot find a new better path, but at the same time it is not needed because the flow is working using the old paths that are now ok. In this case the reroute is not needed and skipped. In the history we can see messages about the skipped rerouting, so that we can distinguish it with a rerouting that allocates new resources.
The message in the history that reroute is unsuccessful in this case is now removed.
closes #5291