Fix async error handling in DispatchIncidentButton: await newIncidentDispatchAction dispatch#4097
Merged
stephenhand merged 2 commits intoCHI-3647-fix_componentfrom Mar 26, 2026
Merged
Conversation
4 tasks
…nly shown on success and errors propagate to catch block Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com> Agent-Logs-Url: https://github.com/techmatters/flex-plugins/sessions/8ff858da-fa0e-4668-bc0f-ba268cb2ea83
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on CHI-3647: Update EditCaseOverview component changes
Fix async error handling in DispatchIncidentButton: await newIncidentDispatchAction dispatch
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
newIncidentDispatchActionis an async action that performs network calls. Withoutawait, the success notification was shown immediately regardless of outcome, and async failures escaped thetry/catchblock, potentially surfacing as unhandled promise rejections.Description
Added
awaitbefore dispatchingnewIncidentDispatchActionso that:try/catchand show the error notificationChecklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.