[codex] Clear stale output samples on underrun#152
Open
failuresmith wants to merge 1 commit intoteamclouday:mainfrom
Open
[codex] Clear stale output samples on underrun#152failuresmith wants to merge 1 commit intoteamclouday:mainfrom
failuresmith wants to merge 1 commit intoteamclouday:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
This issue was caused by
process_audioleaving part or all of the output slice untouched when the ring buffer did not have enough bytes for a full callback. In those underrun paths, CPAL reused whatever values were already present indata, which replayed stale samples and sounded like duplicated audio.The fix is to treat underruns as silence by default and then overwrite only the samples we actually received.
Impact
Validation
cargo fmt --checkcargo clippy --lib --tests --all-features -- -D warningscargo test --lib --all-featurescargo check --lib --tests --all-featurescargo build --lib --tests --all-featuresNotes
Repository-wide
cargo clippy --all-targets --all-features -- -D warningsstill reports an existingbenches/audio.rswarning unrelated to this patch.