Conversation
erikherberg
left a comment
erikherberg
left a comment
There was a problem hiding this comment.
Since this setup is inspired by https://github.com/antfu/eslint-config, note that there is also an issue regarding this: antfu/eslint-config#767 (comment)
| * Many stylistic rules are handled by formatters like Prettier or Biome. | ||
| * This file maintains the stylistic preferences from the original ESLint config. |
There was a problem hiding this comment.
@patrickschroeter note Maybe we should look into using one of those? The main problem i have with the stylistic rules is that only one can be autofixed at a time. E.g. update code to use multiple lines -> Update indentation -> ...
| files: ['**/*.js', '**/*.mjs'], | ||
| includeStylistic: true, | ||
| includeJsdoc: true, |
There was a problem hiding this comment.
@patrickschroeter nitpick That is already the default configuration
| @@ -0,0 +1,21 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2024 TEAM23 | |||
There was a problem hiding this comment.
@patrickschroeter nitpick Maybe we should not use any year at all in our licence
|
|
||
| ## About | ||
|
|
||
| This package provides an oxlint configuration that mirrors the ESLint rules from `@team23/eslint-config-team23-standard`. Oxlint is a high-performance JavaScript linter built with Rust that offers significantly faster linting compared to ESLint. |
There was a problem hiding this comment.
@patrickschroeter question If @team23/eslint-config-team23-standard gets updated, do we need to keep this in sync?
There was a problem hiding this comment.
Without spending too much time on this matter, couldn't we just use https://oxc.rs/blog/2025-10-09-oxlint-js-plugins.html?
| #### Using npx with jiti (recommended for development) | ||
|
|
||
| ```bash | ||
| npx --yes nx build --excludeTaskDependencies | ||
| npx jiti generate-config.ts | ||
| ``` | ||
|
|
||
| #### Using tsx (TypeScript runner) | ||
|
|
||
| ```bash | ||
| npx --yes nx build --excludeTaskDependencies | ||
| npx tsx generate-config.ts | ||
| ``` |
There was a problem hiding this comment.
@patrickschroeter note I would limit this to one setup which we should use.
| "no-console": ["error", { | ||
| "allow": ["warn", "error", "dir", "timeLog", "assert", "clear", "count", "countReset", "group", "groupEnd", "table", "dirxml", "groupCollapsed", "Console", "profile", "profileEnd", "timeStamp"] |
| ## License | ||
|
|
||
| MIT |
There was a problem hiding this comment.
@patrickschroeter nitpick Already included as separate file
| ### Core JavaScript Rules | ||
|
|
||
| All core JavaScript quality rules from the ESLint configuration are included: | ||
| - No magic numbers | ||
| - Prefer const over let | ||
| - No var declarations | ||
| - Proper equality checks | ||
| - And many more... |
| ### Run Oxlint | ||
|
|
||
| ```bash | ||
| # Lint all JavaScript files | ||
| npx oxlint | ||
|
|
||
| # Lint specific files | ||
| npx oxlint src/**/*.js | ||
|
|
||
| # Lint with auto-fix | ||
| npx oxlint --fix | ||
| ``` |
There was a problem hiding this comment.
@patrickschroeter suggestion I would just link to the oxlint documentation.
2 participants
Summary of Changes
Open Todos