Merged
Conversation
Move ED25519 webhook signature verification to telnyx-lib/ module to ensure it persists across Stainless code generation runs. The generated WebhookServiceImpl.kt has 'File generated' header and could be overwritten on the next codegen, losing the ED25519 logic. New files in telnyx-lib/ (preserved across codegen): - WebhookVerification.kt: Standalone ED25519 verification - WebhookVerificationTest.kt: Unit tests for verification logic Features: - ED25519 signature verification using Java's native crypto - Headers: telnyx-signature-ed25519, telnyx-timestamp - 5-minute timestamp tolerance for replay attack prevention - Supports both Map<String, String> and SDK Headers type - Detailed error messages via WebhookVerificationException Usage: import com.telnyx.sdk.lib.WebhookVerification WebhookVerification.verify(payload, headers, publicKey) Follows custom code guidelines from sdk-knowledge.md.
…to telnyx-lib Remove duplicate ED25519 verification code from generated WebhookServiceImpl.kt and delegate to the custom WebhookVerification class in telnyx-lib. Changes: - WebhookServiceImpl now imports and delegates to WebhookVerification.verify() - Removed all duplicate ED25519 crypto code (150+ lines) - Added telnyx-lib dependency to telnyx-core - Removed telnyx-core dependency from telnyx-lib (broke circular dependency) - Removed Headers-based overload from WebhookVerification (not needed) - WebhookServiceImpl converts Headers to Map before calling verification Benefits: - ED25519 logic is now in telnyx-lib (protected from codegen overwrites) - Generated code is now minimal and delegates to custom lib - No code duplication between generated and custom code - Tests pass for both telnyx-lib and telnyx-core Tested: - ./gradlew :telnyx-lib:build :telnyx-core:build (success) - All tests pass
feat(lib): add ED25519 webhook verification to telnyx-lib
Contributor
Author
|
🤖 Release is at https://github.com/team-telnyx/telnyx-java/releases/tag/v6.39.0 🌻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Release PR
6.39.0 (2026-03-31)
Full Changelog: v6.38.1...v6.39.0
Features
Bug Fixes
Refactors
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions