Use luatest from parent directory if available#459
Merged
Conversation
|
coverage: 62.585% (-0.007%) from 62.592% — locker/use-parent-luatest into master |
locker
added a commit
to locker/tarantool
that referenced
this pull request
May 8, 2026
Since commit 066b1c6 ("test: bump test-run to new version"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459. NO_DOC=build NO_TEST=build NO_CHANGELOG=build
sergepetrenko
approved these changes
May 12, 2026
ligurio
approved these changes
May 13, 2026
Currently, test-run requires luatest to be installed from rocks. It is okay for most tarantool-based projects but it isn't really convenient for tarantool itself: in order to install luatest from rocks, one has to install the tt and tarantool packages because tt will refuse to install anything from rocks if tarantool binary or headers are unavailable. This means that to test a freshly built tarantool, one has to install tarantool first, which sounds strange. True, one can make tt use a freshly built tarantool's binary and headers, but it's tricky. Let's instead make test-run use luatest from the parent directory and ship luatest as a submodule in the main Tarantool repository. Note, that if there's luatest installed from rocks in the current source tree, it will still have a higher priority.
locker
force-pushed
the
locker/use-parent-luatest
branch
from
415ca8e to
a58ef59
Compare
locker
added a commit
to locker/tarantool
that referenced
this pull request
May 14, 2026
Since commit 066b1c6 ("test: bump test-run to new version"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459. NO_DOC=build NO_TEST=build NO_CHANGELOG=build
locker
added a commit
to tarantool/tarantool
that referenced
this pull request
May 14, 2026
Since commit 066b1c6 ("test: bump test-run to new version"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459. NO_DOC=build NO_TEST=build NO_CHANGELOG=build
locker
added a commit
to tarantool/tarantool
that referenced
this pull request
May 14, 2026
Since commit 066b1c6 ("test: bump test-run to new version"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459. NO_DOC=build NO_TEST=build NO_CHANGELOG=build (cherry picked from commit 97a3b38)
locker
added a commit
to tarantool/tarantool
that referenced
this pull request
May 14, 2026
Since commit 066b1c6 ("test: bump test-run to new version"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459. NO_DOC=build NO_TEST=build NO_CHANGELOG=build (cherry picked from commit 97a3b38)
locker
added a commit
to tarantool/tarantool
that referenced
this pull request
May 14, 2026
Since commit 066b1c6 ("test: bump test-run to new version"), luatest isn't shipped with test-run anymore. Instead, developers are supposed to install it from rocks. It isn't really convenient because to do it, you have to install the tt and tarantool packages first, i.e. to test tarantool built from sources you have to install the tarantool binary package first, which looks weird. True, one can make tt use a freshly built tarantool's binary and headers, but that's tricky. Let's add luatest as a submodule to the tarantool repository. This makes test-run use it if it doesn't find luatest in rocks, see tarantool/test-run#459. NO_DOC=build NO_TEST=build NO_CHANGELOG=build (cherry picked from commit 97a3b38)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, test-run requires luatest to be installed from rocks. It is okay for most tarantool-based projects but it isn't really convenient for tarantool itself: in order to install luatest from rocks, one has to install the tt and tarantool packages because tt will refuse to install anything from rocks if tarantool binary or headers are unavailable. This means that to test a freshly built tarantool, one has to install tarantool first, which sounds strange. True, one can make tt use a freshly built tarantool's binary and headers, but it's tricky. Let's instead make test-run use luatest from the parent directory and ship luatest as a submodule in the main Tarantool repository. Note, that if there's luatest installed from rocks in the current source tree, it will still have a higher priority.