api: unexport Stream fields, add Id() accessor#588
Merged
Conversation
oleg-jukovec
requested changes
May 12, 2026
Make Stream.Id and Stream.Conn unexported, turning Stream into an opaque handle. This enforces encapsulation and prevents unsafe direct mutation (e.g. stream.Conn = nil). Neither the stream identifier nor the underlying connection is reachable from outside the package — callers should hold their own *Connection reference if they need it. - Rename Stream.Id/Stream.Conn to Stream.id/Stream.conn. - Drop TestStream_IdValues: it only existed to push synthetic stream ids through a Stream; MP_UINT encoding is covered elsewhere. - Document the breaking change in CHANGELOG.md and MIGRATION.md. Closes #471
bigbes
force-pushed
the
bigbes/gh-471-unexport-stream-fields
branch
from
cd8ab3d to
2e664eb
Compare
oleg-jukovec
approved these changes
May 15, 2026
sssciel
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream.IdandStream.Conn(v3 breaking change) to enforce encapsulation and prevent unsafe direct mutation likestream.Conn = nil.Stream.Id() uint64accessor; the underlying connection is no longer reachable from outside the package.Closes #471