Skip to content

Added Label Search and Pagination#5

Open
mileswhiteford wants to merge 7 commits intotapilab:mainfrom
mileswhiteford:feature/pagination
Open

Added Label Search and Pagination#5
mileswhiteford wants to merge 7 commits intotapilab:mainfrom
mileswhiteford:feature/pagination

Conversation

@mileswhiteford
Copy link
Copy Markdown
Collaborator

Features

  • Filter search results by label (any/all match), with or without query
  • Paginated results (10 per page)
  • Fixed page ordering in sidebar and corresponding file names
  • Cleaned up unused .env vars, updated README

@martintony4all
Copy link
Copy Markdown
Collaborator

@mileswhiteford

I’ve reviewed the PR. Here are some comments:

  1. The pagination appears to be done well. However, I noticed the 'mode' and 'vector k' features appears to not contribute to search. Each pages displays 10 search results irrespective of what vector k is set to, and changing the 'Mode' from 'keyword' to 'hybrid/vector' appears to do/show nothing. Is it possible to know what this vector k feature will do in relation to the pagination and try to make them interact? For example, a user increasing 'vector k' from 10 to 20 searches on a page will show a reduced number of pages for the pagination.

  2. In System Diagnostics page the Azure OpenAI (AZURE_OPENAI_KEY) configuration now shows Not configured. Should be tested in .env and added to ReadMe also?. Adding to the .env file kept showing same error. Try to see its green, so that merging does not invalidate current implementation.

@mileswhiteford
Copy link
Copy Markdown
Collaborator Author

Hey Martin, thanks for the comments!

You're right, having a vector k slider was pretty redundant when using pagination, so I have made vector k change based on the page you are on to make sure that the results are always relevant and in order. For simplicity, each page will contain 10 results. Although, I'm not sure why issues were happening with mode not having an effect on the search, that implementation still seems to work for me. Let me know if you continue to encounter that problem.

In regards to the missing OpenAI environmental variables, thats my bad, I forgot to add those to the readme, so that has been updated. I believe to get rid of the error you have to add both the AZURE_OPENAI_KEY and AZURE_OPENAI_ENDPOINT to the ui/.env file. Could you let me know where to find these keys so I can add them to the .env variable pdf I shared with you the other day? Once those are configured everything should be working.

Please let me know if you encounter any more problems with these updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants