Skip to content

fix browser detection for install instructions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clstokes wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix browser detection for install instructions #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ chrome.runtime.onConnect.addListener((port) => {

// browserByte returns either "F" for Firefox or "C" for chrome.
// Other browsers return "?".
// Firefox aliases `chrome.*` to its `browser.*` APIs, so
// `chrome.runtime.getURL` works on both; the returned scheme is what differs.
// See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Chrome_incompatibilities
function browserByte() {
if (typeof chrome !== "undefined") {
if (typeof browser !== "undefined") {
return "F"; // Firefox supports both `chrome` and `browser`
}
return "C";
}
const url = chrome.runtime.getURL("");
if (url.startsWith("moz-extension://")) return "F";
if (url.startsWith("chrome-extension://")) return "C";
return "?";
}

Expand Down