Skip to content

Windows support#16

Open
shrijayan wants to merge 2 commits into
tailscale:mainfrom
shrijayan:windows-support
Open

Windows support#16
shrijayan wants to merge 2 commits into
tailscale:mainfrom
shrijayan:windows-support

Conversation

@shrijayan
Copy link
Copy Markdown

Summary

  • Add Windows support for native messaging host install/uninstall via registry (HKCU) for both Chrome and Firefox
  • Split log/syslog usage into platform-specific files since it's unavailable on Windows — no-op on Windows, existing behavior preserved elsewhere
  • Handle .exe binary suffix and forward-slash JSON paths on Windows
  • Fix popup login link to actually open the auth URL via chrome.tabs.create instead of being a dead #login href
  • Clean up dead code (browseToURL, lastStatus), add explicit //go:build windows tag, extract binaryName() helper

New files

  • registry_windows.go — creates/deletes NativeMessagingHosts registry keys under HKCU
  • registry_other.go — no-op stubs for non-Windows
  • syslog_other.go — extracted existing syslog setup (was inline in main())
  • syslog_windows.go — no-op since log/syslog doesn't exist on Windows

Add Windows native messaging host registration via the registry,
split syslog setup into platform-specific files since log/syslog
is unavailable on Windows, handle .exe binary suffix, and fix the
popup login link to actually open the auth URL.

Signed-off-by: shrijayan <81805145+shrijayan@users.noreply.github.com>
Remove unused browseToURL function and lastStatus variable from
popup.js, add explicit //go:build windows tag to registry_windows.go,
and extract binaryName() to deduplicate the platform-conditional
binary naming in install/uninstall.

Signed-off-by: shrijayan <81805145+shrijayan@users.noreply.github.com>
@pl4nty
Copy link
Copy Markdown

pl4nty commented May 2, 2026

Dupe of #14?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants