Add DisableFunction API#109
Conversation
oxtoacart
force-pushed
the
percy/disable-func
branch
3 times, most recently
from
354e841 to
d6350c3
Compare
alexwlchan
left a comment
alexwlchan
left a comment
There was a problem hiding this comment.
🎉
One suggestion but it's a tiny one; happy for you to merge as-is if you prefer.
| } | ||
| defer conn.Close() | ||
|
|
||
| exec(t, conn, "CREATE TABLE t (c)") |
There was a problem hiding this comment.
Minor: I would skip creating the table; SQLite allows you to run SQL functions without applying them to a table (SELECT LOWER('Hi') is a complete query).
This allows built-in functions to be disabled. Updates tailscale/corp#31396 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
percy/disable-func
branch
from
d6350c3 to
64d27a8
Compare
| // DisableFunction disables an existing function (including built-ins) using | ||
| // sqlite3_create_function. The name and numArgs must match the existing | ||
| // function's signature. | ||
| // |
There was a problem hiding this comment.
Minor nit
| // DisableFunction disables an existing function (including built-ins) using | |
| // sqlite3_create_function. The name and numArgs must match the existing | |
| // function's signature. | |
| // | |
| // DisableFunction disables an existing function (including built-ins) using | |
| // sqlite3_create_function. The name and numArgs must match the existing | |
| // function's signature. |
It is probably also worth noting that we "disable" it by replacing that function name with a stub that does nothing, rather than making it report an error. That might be relevant to someone debugging.
| } | ||
|
|
||
| // DisableFunction disables the named function on the given connection. | ||
| // numArgs must match the number of args of the function to be disabled. |
There was a problem hiding this comment.
As written, this will also let you "create" new previously non-existing no-op functions. That's harmless, but someone who misspells the function name they wanted to disable could easily be confused as there's no error to say "that doesn't exist".
Is it practical to look up the requested function first, and use that to report an error if someone tries to "disable" a function that isn't there? (E.g., we could query select name, narg from pragma_function_list where name = 'fname'). That would also have the incidental benefit that we wouldn't need to know the argument count a priori.
Not positive it's worth it, but this should be uncommon enough that it might be worth the extra step.
3 participants
This allows built-in functions to be disabled.
Updates tailscale/corp#31396