fix: enqueue script with correct name (take into account full name)#8
Open
weber-s wants to merge 1 commit intotailpress:mainfrom
Open
fix: enqueue script with correct name (take into account full name)#8weber-s wants to merge 1 commit intotailpress:mainfrom
weber-s wants to merge 1 commit intotailpress:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running vite with devserver, the JS is not loaded as module and so we get "import declarations may only appear at top level of a module" and so on.
This PR fix the filter to load the script tag to match the correct filename (add the asset flename to the base handle).
To reproduce the bug simply add an import in the
ressource/js/app.jslike:and run
npm run dev, to get the error. This PR fix it.Thank for tailpress!