feat(jsonrpc): add stdio-based json-rpc server with forge api integration#2896
Draft
amitksingh1490 wants to merge 4 commits intomainfrom
Draft
feat(jsonrpc): add stdio-based json-rpc server with forge api integration#2896amitksingh1490 wants to merge 4 commits intomainfrom
amitksingh1490 wants to merge 4 commits intomainfrom
Conversation
github-actions
bot
added
the
type: feature
tusharmath
reviewed
Apr 9, 2026
| .unwrap_or_else(|| PathBuf::from(".")); | ||
|
|
||
| // Initialize the API | ||
| let api = Arc::new(ForgeAPI::init(cwd, config, services_url)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| let api = Arc::new(ForgeAPI::init(cwd, config, services_url)); | |
| let api = Arc::new(ForgeAPI::init(cwd, config)); |
Config already have service url
tusharmath
reviewed
Apr 9, 2026
crates/forge_main/Cargo.toml
Outdated
| path = "src/main.rs" | ||
|
|
||
| [[bin]] | ||
| name = "forge-jsonrpc" |
Collaborator
There was a problem hiding this comment.
Can't do two bins. We need to ship 1 bin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.