Skip to content

Fix missing default value for ‘all-features’ causing build errors#114

Merged
taiki-e merged 1 commit intotaiki-e:mainfrom
ftnfurina:main
Mar 18, 2026
Merged

Fix missing default value for ‘all-features’ causing build errors#114
taiki-e merged 1 commit intotaiki-e:mainfrom
ftnfurina:main

Conversation

@ftnfurina
Copy link
Contributor

When my workflows configuration does not include “all-features”, the build fails with the error: Error: ‘all-features’ input option must be ‘true’ or ‘false’: ‘’

      - name: Build giaa and upload assets
        uses: taiki-e/upload-rust-binary-action@v1
        with:
          bin: giaa
          locked: true
          target: x86_64-pc-windows-msvc
          token: ${{ secrets.GITHUB_TOKEN }}
          zip: windows
          archive: $bin-$tag
          leading-dir: true
          include: README.md,scripts,metadata,settings.yaml
          # all-features: false # This parameter needs to be manually added, as the default value is not set.

Ref: Actions job - Build giaa and upload assets

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 0f1e377 into taiki-e:main Mar 18, 2026
24 checks passed
@taiki-e
Copy link
Owner

taiki-e commented Mar 18, 2026

Published in v1.29.1. Sorry for the breakage and thanks again for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants