Skip to content

952: Reverted "952: Lowered maximum pool size to 1 in app yml"#901

Open
Arshadul-Monir wants to merge 1 commit intomainfrom
952-2
Open

952: Reverted "952: Lowered maximum pool size to 1 in app yml"#901
Arshadul-Monir wants to merge 1 commit intomainfrom
952-2

Conversation

@Arshadul-Monir
Copy link
Copy Markdown
Collaborator

@Arshadul-Monir Arshadul-Monir commented Apr 15, 2026

952

Description of changes

Reverted the change to limit max pool to 1 connection

Checklist before review

  • I have done a thorough self-review of the PR
  • Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
  • If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
  • All tests have passed
  • I have successfully deployed this PR to staging
  • I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Staging

@github-actions
Copy link
Copy Markdown
Contributor

Available PR Commands

  • /ai - Triggers all AI review commands at once
  • /review - AI review of the PR changes
  • /describe - AI-powered description of the PR
  • /improve - AI-powered suggestions
  • /deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

@github-actions
Copy link
Copy Markdown
Contributor

Title

952: Reverted "952: Lowered maximum pool size to 1 in app yml"


PR Type

Enhancement


Description

  • Reverts Hikari connection pool size.

  • Removes maximum-pool-size limit in staging.

  • Restores default database connection behavior.


File Walkthrough

Relevant files
Configuration changes
application-stg.yml
Removed explicit Hikari connection pool size limit             

src/main/resources/application-stg.yml

  • Removed the spring.datasource.hikari.maximum-pool-size property.
  • This change reverts the explicit setting of the Hikari connection pool
    size to 1.
  • Restores the default or previously configured maximum pool size for
    the staging environment.
+0/-5     

@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@Arshadul-Monir
Copy link
Copy Markdown
Collaborator Author

/deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant