Conversation
jjustin
force-pushed
the
rpm
branch
2 times, most recently
from
023397b to
708ac75
Compare
dominikznidar
left a comment
dominikznidar
left a comment
There was a problem hiding this comment.
Nicely done but needs some polishing.
rpm/README.md
Outdated
| Install package | ||
| ``` | ||
| su | ||
| yum install <package name> |
There was a problem hiding this comment.
Just use sudo one liner.
| Don't forget to increase the timeout of lambda function | ||
|
|
||
| If somebody tries to inject a malicious rpm file in your repo it will be automaticly added to repository. It is your job to make bucket secure enough for this not to happen.!!! | ||
|
|
There was a problem hiding this comment.
Take notes from the other MR into account.
rpm/README.md
Outdated
|
|
||
| ## Notes | ||
|
|
||
| .rpm and repodata/* in repository directory are and should be publicly accessible |
There was a problem hiding this comment.
I think bullets (*) could improve readability of this section.
rpm/s3rpm.py
Outdated
| if os.environ['REPO_DIR'].endswith('/'): | ||
| os.environ['REPO_DIR'] = os.environ['REPO_DIR'][:-1] | ||
| if os.environ['REPO_DIR'].startswith('/'): | ||
| os.environ['REPO_DIR'] = os.environ['REPO_DIR'][1:] |
There was a problem hiding this comment.
I think os.environ[X] should be treated as a readonly global variable even though python allows you to change it. Updates like this can introduce some weird and unexpected side effects.
repoDir = os.environ['REPO_DIR'].strip('/') # is good enough :)| Don't forget to increase the timeout of lambda function | ||
|
|
||
| If somebody tries to inject a malicious rpm file in your repo it will be automaticly added to repository. It is your job to make bucket secure enough for this not to happen.!!! | ||
|
|
There was a problem hiding this comment.
Instructions for running unit tests should be added.
rpm/README.md
Outdated
| ``` | ||
| git clone https://github.com/tactycal/lambdaRepos.git | ||
| cd lambdaRepos/rpm | ||
| pip3 install -t . -r requirements.txt |
There was a problem hiding this comment.
Dependencies are not stated here. It's always a good idea for the first second level title to be Requirements section.
rpm/Makefile
Outdated
| pip3 install -t . -r requirements.txt --upgrade | ||
|
|
||
| package: | ||
| zip code.zip $(ZIPPED) |
There was a problem hiding this comment.
test target would be useful.
jjustin
force-pushed
the
rpm
branch
2 times, most recently
from
4b7834a to
1aae37c
Compare
jjustin
force-pushed
the
rpm
branch
3 times, most recently
from
1b695f6 to
5592f79
Compare
…f it is overwritten
2 participants
Script for maintaining repositories with RPM packages
Details on how to use are included in Readme.md