Treat <ol> like <ul> when parsing as HTML#23
Open
cyanogilvie wants to merge 4588 commits intotDOM:masterfrom
Open
Treat <ol> like <ul> when parsing as HTML#23cyanogilvie wants to merge 4588 commits intotDOM:masterfrom
cyanogilvie wants to merge 4588 commits intotDOM:masterfrom
Conversation
…ase of entity serialization.
…ges as result of TIP 699.
…L reader Uses the machinery to accept HTML5 custom element names.
…L reader now accept HTML5 custom element names.
…t feature turned out to be cumbersome and with unwanted fall out so this first backs out this to perhaps find something better.
…e that (with first looking at the selectNodesNamespaces mapping for full control) and error out if it doesn't resolve. Still to decide what to do with XML namspace declaration attributes.
…ripts. There are corner cases in really pathological scenarious but for a broad range of practical needs this should work pretty well and intuitively.
…called with only one argument.
…at build time. Added tests regarding the nodeList argument of scriptend XPath functions.
…res. Thanks to Peter Piwowarski for his valuable input.
Added test cases exercising the html parsing of <ul> and <ol>. Currently they still fail because <ul><li>first<li>second</ul> is interpreted as <ul><li>first<li>second</li></li></ul> instead of <ul><li>first</li><li>second</li></ul>
…rror, don't add the node or set the result to the nodecmd
…y will be spurious text nodes in the resulting DOM
Add domSetAttributeEx (length-explicit variant of domSetAttribute) to dom.c, and expose it along with tcldom_createNodeObj, domCloneNode, domCreateDoc, domCreateDocument, domSetDocumentElement, domFreeDocument, domNewElementNode, domAppendNewTextNode, and domAppendChild via the stubs table (slots 19-28). Update test expectations for HTML serialization newline suppression and mark li auto-close tests as knownBug. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<ol>
<li>first
<li>second
</ol>
was failing to parse with -html set. This patch adds the <ol> tag to the set that trigger autoclose.
I also added test cases to highlight the incorrect nesting of the <li> child nodes when this doc is parsed.