Fix error in zram-generator.conf.example#240
Conversation
`xenstore-read` returns values in KiB, at least for this key. Signed-off-by: Atrate <Atrate@protonmail.com>
…ility does Signed-off-by: Atrate <Atrate@protonmail.com>
Signed-off-by: Atrate <Atrate@protonmail.com>
|
Additionally, it may be a good idea to change |
But those are not equivalent. What you see is Qubes OS defaults: PVH uses hotplug, but HVM does not. And also, most use of HVM (at least by default) is for PCI devices, which also makes it not really compatible with any kind of dynamic memory management, so in that case you can as well take the size Linux sees at boot, not some Xen-specific value, as it won't change at runtime. |
|
As far as I'm reading this, then, there will not be one solution for each type of Qubes/Xen VM. Let's leave the example as-is, this got too Xen-specific for this repo. |
At least on my system,
xenstore-readalways returns values inKiB, notMiB. This lead to an error in the example config. This PR also simplifies thexenstore-readcall with a shorthand, thanks to @marmarek for that idea.