ci: improve sysdig client test coverage#81
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves test coverage for Sysdig client authentication/context helpers by exercising the real client against httptest servers (rather than isolated RequestEditorFn unit tests).
Changes:
- Refactors duplicated test server logic into a reusable
permissionsHandler. - Adds coverage for context helpers (
GetTokenFromContext,GetHostFromContext) including panic paths. - Adds authentication/versioning tests for
WithHostAndTokenFromContext,WithFallbackAuthentication, andWithVersion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alecron
approved these changes
Apr 27, 2026
dangaiden
pushed a commit
that referenced
this pull request
May 7, 2026
4 functions in client.go had 0% coverage (GetTokenFromContext, GetHostFromContext, WithFallbackAuthentication, WithVersion). New tests exercise auth strategies through the actual client against httptest servers, not as isolated RequestEditorFn unit tests. Refactors duplicated handler into shared permissionsHandler across TLS and auth tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 functions in client.go had 0% coverage (GetTokenFromContext, GetHostFromContext, WithFallbackAuthentication, WithVersion). New tests exercise auth strategies through the actual client against httptest servers, not as isolated RequestEditorFn unit tests.
Refactors duplicated handler into shared permissionsHandler across TLS and auth tests.