fix: cleanup unpaid order transfers from migration#466
Open
fix: cleanup unpaid order transfers from migration#466
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
From the logs, there is no on-chain balance. The mismatch from total comes from the invalid pending transfer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #461
Description
This PR fixes a bug where unpaid/expired Blocktank orders from the RN backup's
paidOrdersmap were imported as pending transfers during migration, permanently locking funds inbalanceInTransferToSpending.The RN app could store orders in
paidOrderseven when the payment was never completed. The migration code blindly trusted this map and only filtered out.executedorders, allowing expired/unpaid orders through.Changes:
.paidstate (not just skipping.executed)amountSatsto useclientBalanceSatinstead ofclientBalanceSat + feeSat, matching the normal transfer creation flowsyncTransferStatesso any invalid transfers get cleaned up during normal syncLinked Issues/Tasks
Screenshot / Video
simulate-migration.mp4
after-fix.mp4
QA Notes:
To reproduce:
blocktank.tswith this file blocktank.ts to create an order without broadcast the paymentcheckForAppUpdate();to don't display the update sheetmasterbranchfix/unpaid-order-import