fix: recover orphaned channel monitors from RN migration#462
Open
fix: recover orphaned channel monitors from RN migration#462
Conversation
…ard that was racing with concurrent syncNodeStatus calls
… another channel in the same batch
Member
Author
|
Failure simulation logs: After mining 146 blocks and run the fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459
This PR adds a one-time post-startup recovery check for orphaned channel monitors from the RN migration. During migration, some channel monitors could silently fail to download from the RN backup server, leaving LDK unable to sweep force-closed channel funds. This recovery mechanism re-fetches those monitors and restarts the node with the recovered data.
Ported from the Android implementation on
fix/reimport-channel-monitor.How it works
checkForOrphanedChannelMonitorRecovery()runs onceRNBackupClientand callsfetchRNRemoteLdkData()to retrieve monitors from the RN backupChanges
MigrationsService: addisChannelRecoveryCheckedflag, makefetchRNRemoteLdkData()public and returnBoolindicating whether all monitors were retrievedWalletViewModel: addcheckForOrphanedChannelMonitorRecovery(), called after node startQA Notes
throw RNBackupError.invalidServerResponse("Retrieve channel_monitor \(channelId) failed") //TODO DON'T COMMITfailure-simulation.mp4
channel-closing-detection.mp4