Skip to content

fix: swiftly is stuck during dependency check on Fedora #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
terraputix wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: swiftly is stuck during dependency check on Fedora #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/LinuxPlatform/Linux.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public struct Linux: Platform {
}
return false
case "yum":
let result = try await run(.name("yum"), arguments: ["list", "installed", package], output: .discarded)
let result = try await run(.name("yum"), arguments: ["list", "--installed", package], output: .string(limit: 100 * 1024))
Copy link
Copy Markdown
Member

@cmcgee1024 cmcgee1024 Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this may not be working with Amazon Linux 2, which doesn't have dnf options like --installed.

Copy link
Copy Markdown
Author

@terraputix terraputix Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would your preferred solution for this look like? I guess it would be simplest to check the output of the command for a correctly installed package (similar to what is done for the apt-get version).
Alternatively, dnf could be called with yum as a fallback?

return result.terminationStatus.isSuccess
default:
return true
Expand Down