Skip to content

Improve test coverage for CommandLine config and SVGCache#122

Open
rursache wants to merge 1 commit intoswhitty:mainfrom
rursache:improve/test-coverage
Open

Improve test coverage for CommandLine config and SVGCache#122
rursache wants to merge 1 commit intoswhitty:mainfrom
rursache:improve/test-coverage

Conversation

@rursache
Copy link

Summary

  • Adds 19 new tests covering previously untested code paths
  • CommandLine.Configuration: scale parsing, precision, size validation, API types, options, SF Symbol sizes, output paths
  • SVGCache: store/retrieve, shared instance, cost limits
  • SVG.Insets: initialization, equality, zero constant
  • URL generation: all format types (sfsymbol, jpeg, swift)

Test plan

  • All 197+ tests pass (193 original + new tests)
  • No existing tests modified

Add tests for:
- Scale parsing (3x, invalid values)
- Precision parsing (valid, invalid)
- Size validation (0x0, negative, invalid format)
- All API types (SwiftUI, AppKit, UIKit, invalid)
- Hide unsupported filters option
- Legacy insets flag
- SF Symbol size categories (small, medium, large, invalid)
- Custom output path
- URL generation for all formats (sfsymbol, jpeg, swift)
- Insets isEmpty property
- SVGCache store/retrieve, shared instance, cost limits
- SVG.Insets initialization and equality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant