Support patternContentUnits=objectBoundingBox for pattern fills#120
Open
rursache wants to merge 1 commit intoswhitty:mainfrom
Open
Support patternContentUnits=objectBoundingBox for pattern fills#120rursache wants to merge 1 commit intoswhitty:mainfrom
rursache wants to merge 1 commit intoswhitty:mainfrom
Conversation
When a pattern uses patternContentUnits="objectBoundingBox", scale the pattern frame to the bounding box of the filled element. This fixes rendering of patterns that reference images via <use> elements in <defs>, where the pattern coordinates are in [0,1] range. Also fixes a bug in firstGraphicsElement(with:) where the search would stop prematurely at the first container element, even if the target element was a later sibling. Closes swhitty#52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patternContentUnits="objectBoundingBox"support for pattern fillsfirstGraphicsElement(with:)where the search would stop prematurely at the first container element, even if the target element was a later siblingTest plan
testDOMPatternObjectBoundingBox()verifying objectBoundingBox patterns preserve content unitstestDOMPatternUserSpaceOnUse()verifying default patterns use userSpaceOnUsefirstGraphicsElementSearchesPastContainers()verifying element lookup doesn't stop at containersCloses #52