Fix CSS @media query parsing error in style elements#119
Open
rursache wants to merge 1 commit intoswhitty:mainfrom
Open
Fix CSS @media query parsing error in style elements#119rursache wants to merge 1 commit intoswhitty:mainfrom
rursache wants to merge 1 commit intoswhitty:mainfrom
Conversation
Skip unknown CSS @ rules (e.g. @media, @supports) including nested blocks when parsing style sheets. Previously the parser would fail when encountering @media queries, printing a parsing error to console. The scanner now tracks brace depth to correctly skip over nested rule blocks while continuing to parse surrounding selectors. Closes swhitty#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rules (e.g.@media,@supports) including nested blocks when parsing style sheets@mediaqueries, printing a parsing error to consoleTest plan
skipsMediaQueries()test verifying@mediablocks are skipped and surrounding selectors are parsedskipsNestedAtRules()test verifying doubly-nested@rules (e.g.@supportscontaining@media) are skippedCloses #59