Add share button to converted files#13
Add share button to converted files#13strawberry-raccoon wants to merge 3 commits intoswe-productivity:mainfrom
Conversation
strawberry-raccoon
force-pushed
the
share-button
branch
2 times, most recently
from
6e4119a to
ef8f822
Compare
| .then((res) => res.text()) | ||
| .then((html) => { | ||
| main.innerHTML = html; | ||
| setupShareButtons(); |
There was a problem hiding this comment.
Also call this when refreshData isn't running like if you go to history to share an old file
C4illin
left a comment
C4illin
left a comment
There was a problem hiding this comment.
Very nice! Do you have any tips for testing this? Couldn't get the share api to work on any browser, does it need a phone browser?
But the code looks correct, just added two very minor comments
strawberry-raccoon
force-pushed
the
share-button
branch
from
38bb0f6 to
20c1b9c
Compare
It has somewhat limited support outside of mobile browsers. For desktop, Chromium supports it as long as your OS has a native share feature (I believe Windows, macOS and ChromeOS). I'd say testing it on mobile is a more realistic experience since those have the most complete share experiences and it's where most people are likely to use this. |
2 participants
Closes #5