Add script to generate versions.adoc#1008
Draft
hardys wants to merge 2 commits intosuse-edge:mainfrom
Draft
Conversation
diconico07
reviewed
Jan 9, 2026
Contributor
diconico07
left a comment
diconico07
left a comment
There was a problem hiding this comment.
Mostly usability comments. This will be a really nice addition 👍
asciidoc/edge-book/versions.adoc.j2
Outdated
| :version-elemental-operator-chart: {{ release_manifest_elemental_version }} | ||
| :version-elemental-operator-crds-chart: {{ release_manifest_elemental_crd_version }} | ||
| :version-endpoint-copier-operator-chart: {{ release_manifest_eco_version }} | ||
| :version-fleet-chart: 108.0.1+up0.14.1 |
Contributor
There was a problem hiding this comment.
I'd group all the "manually handled ones" to make them more visible
hardys
changed the title
Contributor
Author
|
Converting to draft until I have time to rewrite the script |
hardys
added a commit
to hardys/suse-edge.github.io
that referenced
this pull request
Jan 13, 2026
First pass of updates for 3.5.0 - note the versions are derived from suse-edge#1008 but I will follow up with the script changes in another PR The release notes will require further work but this is hopefully a reasonable first pass we can iterate on
hardys
added a commit
that referenced
this pull request
Jan 14, 2026
First pass of updates for 3.5.0 - note the versions are derived from #1008 but I will follow up with the script changes in another PR The release notes will require further work but this is hopefully a reasonable first pass we can iterate on
Several files are commented in the edge.adoc, so lets remove them to clean up and simplify the versions.adoc
hardys
changed the title
Contributor
Author
|
@diconico07 ready for another review when you get time - note this depends on #1088 |
Adds a script/template which allows us to generate the versions derived from the release manifest, hopefully this will be less effort and less error-prone than manual updates
hardys
commented
Mar 23, 2026
| :version-longhorn: 1.10.2 | ||
| :version-neuvector: 5.4.8 | ||
| :version-kubevirt: 1.5.2 | ||
| :version-kubevirt: 0.6.0 |
Contributor
Author
There was a problem hiding this comment.
I think this attribute is unused so can be removed, but the version-kubevirt-release above is wrong, we need to reference the upstream version which isn't actually the +up in this case
diconico07
requested changes
Apr 10, 2026
Comment on lines
+234
to
+242
| kiwi_builder_repo = f"{registry_base}/kiwi-builder" | ||
| kiwi_builder_version = get_latest_version_tag(kiwi_builder_repo) | ||
| # Strip suffix after hyphen (e.g., 10.2.29.1-1.1 -> 10.2.29.1) | ||
| manifest_data['version_kiwi_builder'] = kiwi_builder_version.split('-')[0] | ||
|
|
||
| eib_repo = f"{registry_base}/edge-image-builder" | ||
| eib_version = get_latest_version_tag(eib_repo) | ||
| # Strip suffix after hyphen (e.g., 1.3.3-4.4 -> 1.3.3) | ||
| manifest_data['version_eib'] = eib_version.split('-')[0] |
Contributor
There was a problem hiding this comment.
Those two are now in the tooling manifest
Comment on lines
+249
to
+260
| # Get upgrade-controller chart version | ||
| # Extract major.minor from release version (e.g., 3.5.0 -> 3.5) | ||
| release_version = manifest_data.get('spec', {}).get('releaseVersion', '') | ||
| if release_version: | ||
| version_parts = release_version.split('.')[:2] # Get major.minor | ||
| chart_prefix = version_parts[0] + '0' + version_parts[1] # e.g., 3.5 -> 305 | ||
| # Charts are at registry.suse.com/edge/charts/upgrade-controller (not version-specific) | ||
| registry_name = repository.split('/')[0] | ||
| upgrade_controller_repo = f"{registry_name}/edge/charts/upgrade-controller" | ||
| upgrade_controller_version = get_latest_version_tag_with_prefix(upgrade_controller_repo, chart_prefix) | ||
| # Strip suffix after hyphen (e.g., 305.0.3_up0.1.3-4.1 -> 305.0.3_up0.1.3) | ||
| manifest_data['version_upgrade_controller_chart'] = upgrade_controller_version.split('-')[0] |
Contributor
There was a problem hiding this comment.
Upgrade controller is now in release manifest
| # Render template with manifest data | ||
| output = template.render(manifest_data) | ||
|
|
||
| # Replace %%REVDATE%% with current date |
Contributor
There was a problem hiding this comment.
Why not add current date to the variables available to the template ?
Comment on lines
+17
to
+18
| {%- set release_manifest_akri_version = spec.components.workloads.helm | selectattr("releaseName", "equalto", "akri") | map(attribute="version") | list | first %} | ||
| {%- set release_manifest_akri_dashboard_version = spec.components.workloads.helm | selectattr("releaseName", "equalto", "akri") | map(attribute="addonCharts") | first | map(attribute="version") | list | first %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a script/template which allows us to generate the versions derived from the release manifest, hopefully this will be less effort and less error-prone than manual updates
Note this is a first step which requires running the script manually - in future we can add a check job to enforce its use, and potentially look at ways to automate the updates via a renovate type flow.