Open
Conversation
Contributor
|
Provide a descriptive title to your PR. The title should describe what changes your PR introduces. In the description, you could tell more about what exactly was changed in code style. |
superstruct-bot
requested changes
Dec 27, 2019
Comment on lines
-8
to
+9
| if (req.url === "/user-agent") return respondU(req, res); | ||
| if (req.url.match(/^\/b64\//)) return respondB(req, res); | ||
| if (req.url === '/') return respondHello(req, res) | ||
| if (req.url === '/user-agent') return respondUserAgent(req, res) | ||
| if (req.url.match(/^\/b64\//)) return respondBase64(req, res) |
Contributor
There was a problem hiding this comment.
The refactoring should be in a separate PR.
| function respondU(req, res) { | ||
| const ua = req.headers["user-agent"]; | ||
| res.end(JSON.stringify({ ua })); | ||
| function respondUserAgent (req, res) { |
Contributor
There was a problem hiding this comment.
This PR should include only code that contributes towards the style changes. You mixed style changes and refactoring (functions' names changes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5