fix: apply versioningEnabled in canvases update

[forestileao]

What

• superplane canvases update -f now applies metadata.versioningEnabled from canvas YAML.
• The CLI blocks attempts to disable canvas versioning when organization-level versioning is enabled.

Why

• versioningEnabled is canvas metadata, not part of canvas version updates, so it was being ignored.
• The backend enforces org-level versioning (org > canvas); attempting to disable at the canvas level should be an explicit error.

How

• When YAML explicitly sets metadata.versioningEnabled, the CLI issues an additional PUT /api/v1/canvases/{id} with {"versioningEnabled": <bool>}.
• Toggle logic is now encapsulated in a small planning helper (planCanvasVersioningUpdate) to keep Execute readable.

Tests

• Canvas update tests were simplified using an expectation-based API test server helper to avoid large handlers and make request ordering assertions easier to read.

  

[superplanehq-integration]

👋 Commands for maintainers:

• /sp start - Start an ephemeral machine (takes ~30s)
• /sp stop - Stop a running machine (auto-executed on pr close)

[forestileao]

@cursoragent the current PR is very complex to understand. it has a lot of nesting. And the test is hard to aunderstand too

Take a look also in the undersolved comments from @shiroyasha

[cursor]

Reduced complexity per review feedback

• Refactored canvases update versioning logic out of Execute into small helpers in pkg/cli/commands/canvases/update.go:
  • requestedCanvasVersioningEnabled(...) isolates “did YAML explicitly set it?”
  • planCanvasVersioningUpdate(...) encapsulates the multi-condition logic (addresses @shiroyasha’s “4-condition ifs” + “move logic into helper” feedback) and returns a simple versioningPlan (effectiveEnabled, enableAfterSpecUpdate).

Simplified tests

• Reworked pkg/cli/commands/canvases/update_test.go to use a small expectation-based API test server (newAPITestServer) instead of large per-test handler switch blocks. Each test now reads as an ordered list of expected requests + small inline handlers.

Verification + PR update

• Ran gofmt and go test ./pkg/cli/commands/canvases.
• Committed and pushed the refactor (refactor: simplify canvases update versioning flow) and updated the PR description to reflect the simplification.

  

[shiroyasha]

Looks better.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}