feat: add grafana alert control#3897
Merged
forestileao merged 21 commits intosuperplanehq:mainfrom Apr 13, 2026
Merged
Conversation
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
|
👋 Commands for maintainers:
|
superplane-policy-bot
Bot
requested review from
forestileao,
lucaspin and
shiroyasha
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
…ns and URL support Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
…es and removing redundant code Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
… specifications and enhancing metadata resolution - Updated Setup methods in DeleteSilence and GetSilence to validate specifications before resolving metadata. - Enhanced delete_silence and get_silence mappers to include silence selection metadata. - Modified list_silences mapper to incorporate filter metadata for improved functionality. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
…ypes - Changed the 'startsAt' and 'endsAt' fields from string to expression types for better flexibility. - Updated default values and placeholders to use dynamic expressions. - Simplified descriptions for clarity. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
…and output fields - Added support for evaluating bare and template expressions for 'startsAt' and 'endsAt' in silence creation. - Updated CreateSilenceOutput to include 'startsAt' and 'endsAt' fields in the response. - Modified mappers to display 'startsAt' and 'endsAt' in the output details. - Improved the configuration descriptions for better clarity on accepted formats. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
… fields - Changed 'startsAt' and 'endsAt' fields in the silence creation configuration from expression types to string types for improved clarity and usability. - Updated the response structure to include 'startsAt' and 'endsAt' timestamps in the silence creation output. - Added tests to ensure proper handling of time string inputs and validate configuration field types. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
- Introduced helper functions to build and apply silence details, improving code readability and maintainability. - Consolidated logic for handling timestamps and output fields, ensuring consistent formatting and configuration handling. - Removed redundant code and improved the structure of the getExecutionDetails method. Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
forestileao
reviewed
Apr 10, 2026
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9982573. Configure here.
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
forestileao
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3885
This expands the Grafana integration by adding the following alert control components:
Demo Video
Note
Medium Risk
Adds new Grafana Alertmanager silence CRUD capabilities (create/list/get/delete) across backend client, workflow components, resource listing, and UI mappers; main risk is correctness of new API interactions/time parsing and resource selection metadata.
Overview
Adds first-class Grafana Alertmanager silence control to workflows: new
grafana.createSilence,grafana.listSilences,grafana.getSilence, andgrafana.deleteSilenceactions, plus resource-picker support via a newsilenceintegration resource type.Extends the Grafana HTTP client with silence models and
ListSilences/GetSilence/CreateSilence/DeleteSilencecalls (including robust create-response ID parsing), and wires these into execution outputs/events and setup-time metadata (including building Grafana UI URLs and a sanitizedcreatedBy).Updates the workflow UI mappers/state badges to render silence actions (and refactors shared Grafana base props), adds examples/tests, and expands
docs/components/Grafana.mdxto document the new silence actions.Reviewed by Cursor Bugbot for commit 827ebc2. Bugbot is set up for automated code reviews on this repo. Configure here.