Update run fastapi doc and initial python setup doc per issue 2008#2317
Merged
Update run fastapi doc and initial python setup doc per issue 2008#2317
Conversation
Remove hardcoded FastAPI content from the shared _poetry_new partial, restore poetry add to the FastAPI page, and update initial-setup with poetry env activate guidance and a callout about the Poetry 2.0 change.
kcmartin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2008 — Poetry 2.0+ removed the built-in
poetry shellcommand, breaking the documented workflow.Changes
_poetry_new.erb(shared partial): Removepoetry shell, add a callout about Poetry 2.0+ withpoetry runandpoetry env activatealternativesinitial-setup.html.md: Replacepoetry shellwithpoetry env activate, add note about the shell plugin for users who prefer itfastapi.html.markerb: Restorepoetry add "fastapi[standard]"to the FastAPI page (was previously removed and incorrectly placed in the shared partial)Testing
Verified the full Poetry 2.0 workflow locally with Poetry 2.3.2:
poetry newcreates a project with PEP 621 format ([project]dependencies)poetry add "fastapi[standard]"works correctlypoetry run fastapi devruns the app successfullypoetry shellconfirms the expected error on 2.0+poetry env activateworks as documentedNotes
The related
fly launchscanner issue (not recognizing[extras]in PEP 621 dependencies) was already fixed in superfly/flyctl#4458.