Skip to content

fix(tracked-changes): do not render empty space in TC within lists#2316

Open
palmer-cl wants to merge 13 commits intomainfrom
colep/sd-1949-bug-tracked-changes-list-renders-ghost-blank-items-bc-and
Open

fix(tracked-changes): do not render empty space in TC within lists#2316
palmer-cl wants to merge 13 commits intomainfrom
colep/sd-1949-bug-tracked-changes-list-renders-ghost-blank-items-bc-and

Conversation

@palmer-cl
Copy link
Collaborator

  • list numbering should match Microsoft Word’s visible revision projection. Empty paragraph-mark revision artifacts should not consume visible list counters.
image

@linear
Copy link

linear bot commented Mar 6, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Status: FAIL

The element and attribute mapping for w:ins and w:del inside w:pPr/w:rPr is correct — both §17.13.5.20 and §17.13.5.15 explicitly show these as empty elements used to mark inserted/deleted paragraph marks, with CT_TrackChange as their content model. The w:id, w:author, and w:date attributes are all spec-defined.


Issue: w:authorEmail is not a spec-defined attribute

  • Element: w:ins / w:del (both use CT_TrackChange)
  • Why it fails: CT_TrackChange defines exactly three attributes — w:id, w:author, and w:date. There is no w:authorEmail attribute anywhere in ECMA-376. See https://ooxml.dev/spec?q=CT_TrackChange.
  • File: track-change-run-property-translator.js, line 11
createAttributeHandler('w:authorEmail', 'authorEmail'),  // ← non-existent attribute

This attribute will never match anything in conformant OOXML files, but more importantly it may silently map garbage data if a malformed document carries a stray w:authorEmail attribute. It should be removed.


Everything else looks clean — the structural placement of w:ins/w:del as children of w:pPr/w:rPr, the round-trip encode/decode logic, and the test coverage for the three legitimate attributes all check out.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c1c46f95f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant