Skip to content

fix(cli): fallback function downloads#5352

Open
7ttp wants to merge 1 commit into
supabase:developfrom
7ttp:fix/functions-download-eszip
Open

fix(cli): fallback function downloads#5352
7ttp wants to merge 1 commit into
supabase:developfrom
7ttp:fix/functions-download-eszip

Conversation

@7ttp
Copy link
Copy Markdown
Contributor

@7ttp 7ttp commented May 26, 2026

TL;DR

fixes functions download by falling back

prob:

basically functions download tries docker unbundle first, and that path can fail, even though server side unbundle works. because of that, normal downloads can fail even when deploy succeeded :D

sol:

basically what i did was keep the current behavior as it is , but if that docker path fails with the known mismatch,
the cli now retries with the existing server side unbundle path instead of failing immediately

ref

@7ttp 7ttp requested a review from a team as a code owner May 26, 2026 00:08
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26424931858

Warning

No base build found for commit d9f31cc on develop.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 63.72%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15725
Covered Lines: 10020
Line Coverage: 63.72%
Coverage Strength: 7.05 hits per line

💛 - Coveralls

@7ttp 7ttp marked this pull request as draft May 26, 2026 00:12
@7ttp 7ttp self-assigned this May 26, 2026
@7ttp 7ttp marked this pull request as ready for review May 26, 2026 11:42
@7ttp 7ttp added functions enhancement New feature or request labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

supabase functions download fails with 'invalid eszip v2' — appears to be eszip version skew in the extraction container

2 participants