Open
Conversation
Contributor
Author
|
@sunli829 what do you think? |
Contributor
Author
|
@sunli829 friendly ping |
Contributor
Author
|
@sunli829 another friendly ping, I know these pass unnoticed sometimes on github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
as described in #27 it would be really nice if
Supervisors could be stopped.I would like to propose to add the
.stop_supervisor()method toAddrandContextto achieve this.In this PR I did the following.
ActorEventcalledActorEvent::StopSupervisorwhich is ignored by normalActors but obeyed bySupervisors.You can now call
.stop()to stop theActor(which will lead to a restart by the supervisor) and.stop_supervisor()which will also stop theActorbut inform theSupervisorto not restart.example/supervisor_clear_interval.rsSupervisor::startmethod looked very similar to theActor::startimplementation and since there was already theActorManagerI opted to move them both into the same thing. I took the liberty of renaming it to lifecycle, as the name maybe a bit more familiar.this fixes #27
Thank you