fix: remove unused configPath parameter from loadReviewers()#113
Merged
Conversation
configPath was declared in the function signature but never referenced
in the body — all reviewers are loaded from the built-in directory
(actionPath/reviewers/). The sole call site (index.ts) only passes
{ actionPath }, confirming the parameter is dead.
Also clarified in the issue that `team` is NOT a ghost parameter — it
is actively used on line 42 for team resolution.
Refs: #110
|
最终决策:可合并 本次 PR 移除
📋 各 Reviewer 详细审查结果quality可合并 本次 PR 删除
阻塞项:无 security安全无虞 本次 PR 仅移除了 阻塞项:无 建议项:无 performance性能良好 本次 PR 仅移除了 阻塞项:无 建议项:无 architecture架构合理 移除
阻塞项:无 建议项:无 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
From #110 — 移除
loadReviewers()未使用的configPath和team参数。经核实:
configPath— 确实是幽灵参数。函数体从未引用opts.configPath,所有 reviewer 均从内置目录actionPath/reviewers/加载,不存在从自定义路径加载的逻辑。team— 不是幽灵参数。第 42 行opts.team || env("MULTI_REVIEW_DEFAULT_TEAM") || DEFAULT_TEAM直接使用了opts.team。issue 描述有误。Fix
仅删除
configPath参数声明。唯一调用方index.ts:27只传{ actionPath },无需改动。构建产物 (
dist/index.cjs) 不受影响,因为该参数从未被引用过。Refs #110