Open
Conversation
cameledev
commented
Mar 17, 2026
7856de6 to
efa0d48
Compare
ce51ac6 to
b438c4b
Compare
cameledev
commented
Mar 31, 2026
Comment on lines
+201
to
+203
| # TODO: change how we get metadata_filename | ||
| output_folder = os.getenv("AWS_S3_OUTPUT_FOLDER", "metadata") | ||
| metadata_filename = f"{output_folder}/{recording.id}-metadata.json" |
Collaborator
Author
There was a problem hiding this comment.
What should we do with this ?
bf54fea to
80cca39
Compare
b90bee2 to
8e6e17d
Compare
cameledev
commented
Apr 21, 2026
Comment on lines
+171
to
+172
| recording_datetime, | ||
| owner_timezone, |
Collaborator
Author
There was a problem hiding this comment.
Put back types. Can't recording_datetime be None ?
cameledev
commented
Apr 21, 2026
Comment on lines
+227
to
+228
| worker_id: Optional[str], | ||
| owner_timezone: Optional[str], |
Collaborator
Author
There was a problem hiding this comment.
use | None for consistency
cameledev
commented
Apr 22, 2026
| command: | ||
| - "python" | ||
| - "multi_user_transcriber.py" | ||
| # - "metadata_collector.py" # TODO: FIX THIS |
Collaborator
Author
There was a problem hiding this comment.
Didn't look into this
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Users
Proposal
Build upon: #741
overlap / speaker_duration). Assign name for largest score (if score > threshold).charlie (SPEAKER_2))Example Output
Two speakers, single user/microphone (named Cameledev)